Fix type-var error, in newer versions of mypy #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy complains that `get` should be generic in order to return a generic. The method is in fact dynamic: the cache can contain multiple types. The caller must cast to the type it thinks it is `get`-ing.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 10, 2022
https://build.opensuse.org/request/show/1035015 by user mia + dimstar_suse - Update to 3.4.0 Features * Add method extract_urllib to extract from a urllib.parse.{ParseResult,SplitResult} #gh/john-kurkowski/tldextract#274 Bugfixes * Fix internal type-var error, in newer versions of mypy #gh/john-kurkowski/tldextract#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy complains that
getshould be generic in order to return a generic. The method is in fact dynamic: the cache can contain multiple types. The caller must cast to the type it thinks it isget-ing.