Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi lists 3.6 as supported #242

Closed
whiteowl3 opened this issue Jan 28, 2022 · 4 comments
Closed

pypi lists 3.6 as supported #242

whiteowl3 opened this issue Jan 28, 2022 · 4 comments

Comments

@whiteowl3
Copy link

whiteowl3 commented Jan 28, 2022

installing the current version from pip which lists support for 3.6 will fail on 3.6.

my project has a dependency on this and my 3.6 builds are failing with

    import tldextract

../../../virtualenv/python3.6.7/lib/python3.6/site-packages/tldextract-3.1.2-py3.6.egg/tldextract/__init__.py:3: in <module>

    from .tldextract import extract, TLDExtract

../../../virtualenv/python3.6.7/lib/python3.6/site-packages/tldextract-3.1.2-py3.6.egg/tldextract/tldextract.py:59: in <module>

    from .cache import DiskCache, get_cache_dir

../../../virtualenv/python3.6.7/lib/python3.6/site-packages/tldextract-3.1.2-py3.6.egg/tldextract/cache.py:11: in <module>

    from filelock import FileLock

E     File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/filelock-3.4.2-py3.6.egg/filelock/__init__.py", line 8

E       from __future__ import annotations

E                                        ^

E   SyntaxError: future feature annotations is not defined

filelock has dropped support for 3.6:
tox-dev/filelock#125

@brycedrennan
Copy link
Collaborator

brycedrennan commented Jan 28, 2022

According to Python:

As of 2021-12-23, 3.6 has reached the end-of-life phase of its release cycle

I recommend updating to a newer version of python

Useful calendar of python end-of-life dates by version.

@whiteowl3
Copy link
Author

@whiteowl3 whiteowl3 changed the title build fails for 3.6 due to filelock pypi lists 3.6 as supported Jan 28, 2022
@john-kurkowski
Copy link
Owner

filelock has dropped support for 3.6:
tox-dev/py-filelock#125

This is a py-filelock issue, not an issue caused by this repo. Which you noted, linking to the py-filelock issue, and it's in the final line of the stack trace. You can work around this by installing an earlier version of py-filelock.

Yeah, breaking changes on a patch release are upsetting. That's a "too hot" debate too. 😄 See tox-dev/filelock#126.

@john-kurkowski
Copy link
Owner

breaking changes on a patch release are upsetting … tox-dev/filelock#126.

To be fair to their project, any issue should be rare. That discussion notes that pip 9 and newer honor python_requires, and so those pip versions won't attempt to install the py-filelock version that declares that it drops Python 3.6 support. That's why CI is still passing on this project. @whiteowl3, maybe you're using a very old pip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants