Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you protect cache file against lib updates ? #153

Open
vaab opened this issue Sep 4, 2018 · 1 comment
Open

Could you protect cache file against lib updates ? #153

vaab opened this issue Sep 4, 2018 · 1 comment
Labels
hold: a PR is pending a PR is pending that will address the issue (including if it is "X birds 1 stone") low priority: has trivial workaround

Comments

@vaab
Copy link

vaab commented Sep 4, 2018

I have to manually check version of tldextract to delete the file when tldextract is updated.
What is the rationale of not doing this on the tldextract side ? (by storing the version of tldextract in
the cache file, and simply removing the file and replace it if it doesn't match current version).

Providing this mecanism externally seems really odd to me : I'd like to keep the cache if usable, I'm ready to make the script that will update it automatically every X elapsed time. But in current situation, it seems I have to also check that the cache is usable by tldextract.

What are your thoughts on this topic ?

@floer32
Copy link
Collaborator

floer32 commented Mar 4, 2019

this is a good point.

there is already a somewhat related PR open here: #144

that one is not merge-ready but it would take care of several improvements to the caching behavior (both when you leave the cache file unconfigured/ default, and when you are using custom cache path)


you are encouraged to control your own cache file -- see docs here:

https://github.com/john-kurkowski/tldextract#note-about-caching

that will take care of your issue regardless of when the other PR is merged

@floer32 floer32 added low priority: has trivial workaround hold: a PR is pending a PR is pending that will address the issue (including if it is "X birds 1 stone") labels Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold: a PR is pending a PR is pending that will address the issue (including if it is "X birds 1 stone") low priority: has trivial workaround
Projects
None yet
Development

No branches or pull requests

2 participants