Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to Cargo.toml #151

Closed
JonasHedEng opened this issue Apr 14, 2022 · 3 comments
Closed

Add license to Cargo.toml #151

JonasHedEng opened this issue Apr 14, 2022 · 3 comments

Comments

@JonasHedEng
Copy link

When using cargo deny, exr is reported to be missing a license and I guess the BSD-3 fails to get parsed out of the LICENSE file due to the Dreamworks section?

error[L003]: exr = 1.4.1 is unlicensed
  ┌─ exr 1.4.1 (registry+https://github.com/rust-lang/crates.io-index):2:9
  │
2 │ name = "exr"
  │         ^^^ a valid license expression could not be retrieved for the crate
3 │ version = "1.4.1"
4 │ license = ""
  │            - license expression was not specified
5 │ license-files = [
6 │     { path = "LICENSE.md", hash = 0xf0600744, score = 0.68, license = "Sleepycat" },
  │                                                       ---- low confidence in the license text
  │
  = exr v1.4.1
    └── image v0.24.1
        ├── ark-cli v0.1.1
        │   ├── ark-client v0.4.8
        │   │   ├── ark-client-android v0.2.0
        │   │   └── module-tests v0.1.0
        │   │       └── (dev) ark-module-publish v0.1.0
        │   │           └── ark-cli v0.1.1 (*)
        │   └── module-tests v0.1.0 (*)
        ├── ark-client v0.4.8 (*)
        ├── (dev) ark-render-vulkan v0.1.0
        │   ├── ark-cli v0.1.1 (*)
        │   └── ark-client v0.4.8 (*)
        └── ark-render-vulkan v0.1.0 (*)

So if there aren't any problems with it, additionally adding license = "BSD-3" should make cargo deny happier!

@johannesvollmer
Copy link
Owner

AcademySoftwareFoundation/openexr@a511caa

Seems like they changed it to BSD-3 recently, even confirming to SPDX. So I don't see any problem changing it too

@johannesvollmer
Copy link
Owner

johannesvollmer commented Apr 16, 2022

crate was updated. image-rs might be updated soon too. see image-rs/image#1703

@JonasHedEng
Copy link
Author

Perfect, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants