Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.13.1 quit unexpectedly (Mac arm64) #2503

Closed
jab-ac opened this issue Mar 6, 2023 · 38 comments
Closed

7.13.1 quit unexpectedly (Mac arm64) #2503

jab-ac opened this issue Mar 6, 2023 · 38 comments

Comments

@jab-ac
Copy link

jab-ac commented Mar 6, 2023

I had 7.12.2 installed and running without issue. Updated this morning to 7.13.1 using the .dmg and when I started the app it quit unexpectedly and now I can’t recover it. Tried uninstall and rolling back to previous version, now it’s stuck in a quit loop as well. Tried running it in Safe Mode, no dice. It appears to be complete hosed and I’ve no clue what to do next. Any ideas?

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Hello there jab-ac! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

@jab-ac
Copy link
Author

jab-ac commented Mar 6, 2023

Sorry, I submitted the report from mobile and didn't see the standard format for bug reports, here it is:

Your Environment

Version used: 7.13.1
Operating System and version: MacOS 13.2.1
Hardware: MacBook Pro 14" M1 Pro

Expected Behavior

Copy new version from .dmg to Applications folder and replace the existing file for v7.12.2, then double-click to open and app should start up with existing data and preferences no problem.

Current Behavior

Immediately after copying the new version over the old one and starting the app, I received a generic error "superProductivity quit unexpectedly." and any attempt to Reopen or Ignore and start again just results in the same error in an endless loop.

Steps to Reproduce (for bugs)

No idea on another system, but no matter what I do now it reproduces every time I try to run the app. I tried downloading the previous version 7.12.2 which was running fine this morning and copying that back over, same error. Tried deleting the app completely removing all files/folders with it using AppCleaner, then installed and ran clean, same error. Did this multiple times with different versions, all same error. Tried installing from homebrew, same error. Tried clean and install in MacOS Safe Mode, same error. I'm completely stumped, it's like the upgrade corrupted some underlying system dependency which I can't see in the logs. Please help!!

Can you reproduce this reliably?

Yes

Error Log (Desktop only)

EDIT:
main.log

@jab-ac
Copy link
Author

jab-ac commented Mar 6, 2023

I can also send you the Apple Problem Reports directly if needed, I grabbed copies and saved but hesitate to post here.

@jab-ac
Copy link
Author

jab-ac commented Mar 7, 2023

Quick update: b/c my entire workflow for multiple clients revolves around this app for tracking hours to Jira, I kept troubleshooting with additional older versions, here's the results:

  • Previously I had tried rolling back to version 7.12.2-arm64 via multiple instal methods, but all failed.
  • I went further back to version 7.11.6-arm64, and it finally started up again.
  • Tried upgrading from there to 7.12.2-arm64 installing by .dmg / replace and it failed again, same error "superProducivity quit unexpectedly".
  • Tried 7.12.2-Intel build installing by .dmg / replace over existing non-working -arm64 build and it worked.
  • Uninstalled with AppCleaner and went back to 7.11.6-arm64 installing by .dmg and then upgraded to 7.12.1-arm64 installing by .dmg / replace and it works.

Now that I think about it, I'm not 100% certain if I was previously running 7.12.2 as stated in original issue report, or whether it was maybe 7.12.1, I just know for sure it was 7.12.something. But it seems like something isn't right with the arm64 build of recent versions, at least on my system.

@johannesjo johannesjo changed the title 7.13.1 quit unexpectedly 7.13.1 quit unexpectedly (Mac arm64) Mar 7, 2023
johannesjo added a commit that referenced this issue Mar 7, 2023
@johannesjo
Copy link
Owner

Hey @jab-ac ! Sorry to hear your having problems. Thank you very much for digging into this! It would be interesting to see what the output is, when starting the app from a terminal. Apart from that the only possible error source for this is electron, but I was unable to find some related issue (surely someone else must have had this problem). I updated electron to the latest version. Hopefully this fixes the issue.

@LordShedy
Copy link

LordShedy commented Mar 7, 2023

Hi,

I have the same problem.

After upgrading to version 7.13.1, I cannot open it because it crashes on startup.

I am attaching a screenshot of the crash and the error log.

Screenshot 2023-03-07 at 15 21 44
error.log

EDIT: I have

Darwin Kernel Version 22.3.0
Macbook Air M1 with macOS Version 13.2.1 (22D68)

EDIT2:

I have resolved the issue by installing version superProductivity-7.13.1-mac.zip instead brew upgrade/install superproductivity

it seems like the Brew contains arm64 version instead of the Apple silicon one.

@jab-ac
Copy link
Author

jab-ac commented Mar 7, 2023

Hey @jab-ac ! Sorry to hear your having problems. Thank you very much for digging into this! It would be interesting to see what the output is, when starting the app from a terminal. Apart from that the only possible error source for this is electron, but I was unable to find some related issue (surely someone else must have had this problem). I updated electron to the latest version. Hopefully this fixes the issue.

Glad to help, I love this app!! I also suspected something to do with Electron, when I get done for the day I'll try the latest build again and update accordingly. Thanks!

@thinktapper
Copy link

I also experienced this issue when upgrading to 7.12.2 last month. Downgraded to 7.12.1 to fix temporarily

@vicmosin
Copy link
Contributor

Any estimates when it gets fixed in brew? Maybe as a separate cask or something? I find installing it separately is a bit annoying especially when one has to update it in the future.

@johannesjo
Copy link
Owner

Thanks @vicmosin ! We still would need help to properly set this up with cask.

@vicmosin
Copy link
Contributor

@johannesjo do you have any docs how it's currently done?

@johannesjo
Copy link
Owner

No sorry @vicmosin . I didn't even set it up myself. This might give a little bit of a pointer:
#373
brew bump-cask-pr superproductivity --version x.xx.xx
https://github.com/orgs/Homebrew/discussions/561

@eshack94
Copy link

@johannesjo I am experiencing the same issue with the most recent version, 7.13.2 (Mac arm64). I have an M1 Pro MacBook.

No issues with the Intel version. This bug is preventing me from using the software. It looks like there's a segfault somewhere.

@pattkrajnik
Copy link

pattkrajnik commented Jun 1, 2023

Same situation here, every arm64 version later than 7.11.5 if installed with brew fails at startup on Macbook Pro 2022. On Macbook Pro 2015 with every new version works just fine.

@nathanstaton
Copy link

Same happening for me, the only mac arm64 version that works is 7.11.6

@jab-ac
Copy link
Author

jab-ac commented Sep 5, 2023

@johannesjo I'm still using the old 7.12.1 which is the last version I could run without this Electron bug crashing the app. Any update on when this will be fixed so that we can move to a newer version? Thanks again for all your hard work, still a great project!!

@johannesjo
Copy link
Owner

@jab-ac I won't be able to work on this myself, since I don't have the required hardware. So currently there is no eta, but PRs dealing with the problem are always welcome!

@thetric
Copy link
Contributor

thetric commented Sep 8, 2023

Interesting. I have built a version using the following commands:

npm run buildAllElectron:noTests:prod 
CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder --mac mas --config=build/electron-builder.mas.yaml -c.mac.identity=null

and started it via ./app-builds/mas-arm64/Super\ Productivity.app/Contents/MacOS/Super\ Productivity without issues.

Reference:

  • Source: current master
  • Hardware: MacBook Pro (Apple M2 Pro)

@thetric
Copy link
Contributor

thetric commented Sep 8, 2023

According to electron/electron#35355 (comment) it might be necessary to add an entitlement. The Electron docs currently do not include this information. This seems to be related to the Electron 20+ upgrade.

Another suggestion is to drop the entitlements all together

@johannesjo
Copy link
Owner

The entitlement configs are located under ./build. Anybody maybe willing to give the adjustment a shot and see if it works ? Should be the entitlements.mac.plist for the dev build (npm run localInstall:mac), if I am not mistaken.

@jab-ac
Copy link
Author

jab-ac commented Nov 17, 2023

I would give it a shot if I knew how, sorry I can't be of more help. That said, I saw the new version 7.15.0 and figured I'd give try it to see if there's any change, but the same issue occurs.

@therealstein
Copy link

therealstein commented Nov 24, 2023

same issue with
superProductivity-7.15.0-arm64.dmg on M1

after running npm run localInstall:mac

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
	<true/>
	<key>com.apple.security.cs.disable-library-validation</key>
	<true/>
</dict>
</plist>

hopefully it helps @johannesjo

@noname77
Copy link

hey,

thanks for this great tool @johannesjo

I experienced the same issue on my m1 mac and thought I'll give it a go. beware of the long post, I just dumped stuff as I did stuff.

Steps

  • clone the repo
git clone https://github.com/johannesjo/super-productivity.git
cd super-productivity
git log

commit 70d6aaa8eb42e064a893deaf4d4525f35c13b9e5 (HEAD -> master, origin/master, origin/HEAD)
Author: ProfXmas <profxmas@pm.me>
Date:   Thu Nov 23 21:31:25 2023 -0500

    Add trductions to Misc and Sound
  • install dependencies
npm i -g @angular/cli
npm i
<dict>
	<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
	<true/>
	<key>com.apple.security.cs.disable-library-validation</key>
	<true/>
	<key>com.apple.security.cs.allow-jit</key>
	<true/>
</dict>
  • build for Mac with
npm run localInstall:mac
got a missing `embedded.provisionprofile` missing issue
> superProductivity@7.15.0 removeWOFF1
> node ./tools/remove-woff.js


> superProductivity@7.15.0 electron:build
> tsc -p electron/tsconfig.electron.json


  • electron-builder  version=24.6.4 os=22.6.0
  • loaded configuration  file=<PATH_ROOT>super-productivity/electron-builder.yaml
  • writing effective config  file=app-builds/builder-effective-config.yaml
  • packaging       platform=darwin arch=arm64 electron=25.9.0 appOutDir=app-builds/mac-arm64
  • downloading     url=https://github.com/electron/electron/releases/download/v25.9.0/electron-v25.9.0-darwin-arm64.zip size=88 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v25.9.0/electron-v25.9.0-darwin-arm64.zip duration=1m23.54s
  • signing         file=app-builds/mac-arm64/superProductivity.app identityName=Apple Development: My Name (some_id) identityHash=1234_some_hash provisioningProfile=embedded.provisionprofile
  ⨯ Command failed: security cms -D -i embedded.provisionprofile
security: unable to open "embedded.provisionprofile" for reading: No such file or directory
  failedTask=build stackTrace=Error: Command failed: security cms -D -i embedded.provisionprofile
security: unable to open "embedded.provisionprofile" for reading: No such file or directory
                                                                                                                                                                     at ChildProcess.exithandler (node:child_process:419:12)
    at ChildProcess.emit (node:events:511:28)
    at maybeClose (node:internal/child_process:1098:16)
    at Socket.<anonymous> (node:internal/child_process:456:11)
    at Socket.emit (node:events:511:28)
    at Pipe.<anonymous> (node:net:334:12)
From previous event:
    at processImmediate (node:internal/timers:478:21)
From previous event:
    at readDirectoryAndSign (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/macPackager.ts:467:29)
    at MacPackager.signApp (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/macPackager.ts:477:11)
    at MacPackager.doSignAfterPack (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/platformPackager.ts:332:21)
    at MacPackager.doPack (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/platformPackager.ts:317:7)
    at MacPackager.pack (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/macPackager.ts:196:7)
    at Packager.doBuild (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/packager.ts:442:9)
    at executeFinally (<PATH_ROOT>super-productivity/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/packager.ts:376:31)
    at Packager.build (<PATH_ROOT>super-productivity/node_modules/app-builder-lib/src/packager.ts:337:12)
    at executeFinally (<PATH_ROOT>super-productivity/node_modules/builder-util/src/promise.ts:12:14)
npm run localInstall:mac

SUCCESS -> app built to app-builds/superProductivity-7.15.0-arm64.dmg and when copied to Applications it launches successfully.

though there seems to be an issue with copying to target destination, probably parenthesis missing in the cp command:

cp: app-builds/mac/Super Productivity.app/: No such file or directory

additional reference

when I did brew install --cask superproductivity and updated from 7.12.0 to 7.15.0:

==> Upgrading 1 outdated package:
superproductivity 7.12.0 -> 7.15.0

I started to get the crashes, so I downgraded back to 7.12.1 with

brew install --cask https://raw.githubusercontent.com/Homebrew/homebrew-cask/11cbe12a582d4d67f6e77ece3e882148443c4e8c/Casks/superproductivity.rb

which got the app working again

I then tried to download the 7.15.0 arm64 (7.15.0-arm64.dmg) version from releases and installing manually -> same result, the app crashes at startup

I then tried to build myself as described at the top of this post -> SUCCESS, app is launching

for the sake of completeness, I reverted the jit setting and built the app again -> it did't crash either (which also aligns with this comment), so unfortunately not sure if the change is what's doing the job or is it the fact that its built on an apple silicon mac 🤷

best,
wiktor

@johannesjo
Copy link
Owner

Thank you very much @noname77 !!! Just to avoid misunderstandings: What entitlements did you put in which file that ended up working?

@therealstein
Copy link

therealstein commented Dec 1, 2023

<key>com.apple.security.cs.allow-jit</key>

thad did the trick. on m1 macbook

@johannesjo
Copy link
Owner

Thank you @therealstein !

Can you please doublecheck the change? :) If all is will make a new patch release right away.

@therealstein
Copy link

@johannesjo, I just did the same as @noname77 recommended. All kudos go to him!

@johannesjo
Copy link
Owner

The new release is out! Please let me know if it works for you:
https://github.com/johannesjo/super-productivity/releases/tag/v7.15.1

@jab-ac
Copy link
Author

jab-ac commented Dec 5, 2023

Just downloaded the new version 7.15.1 and copied it over the old version 7.12.1 which I've been running since this bug became an issue. It now starts up without crashing and is running as I write this, will monitor and report any further issues, but this looks VERY promising!

I did notice the Dock icon is different, it now has a little bar under it, as shown here:
Screenshot 2023-12-05 at 8 33 27 AM

Is this change intentional? Maybe an artifact on my local system? Interested, but not overly concerned, just happy to be able to update to the latest versions. Thanks to all who contributed to the fix, cheers!!

@johannesjo
Copy link
Owner

Is this change intentional? Maybe an artifact on my local system? Interested, but not overly concerned, just happy to be able to update to the latest versions. Thanks to all who contributed to the fix, cheers!!

Not that I would be aware of. Maybe it's some change on electrons side of things? SP uses the OSs progresss bar feature, so that might be it. If you create a task with "Some task 30m/1h" and start it, does the bar change?

@C00reNUT
Copy link

C00reNUT commented Dec 5, 2023

The new release is out! Please let me know if it works for you: https://github.com/johannesjo/super-productivity/releases/tag/v7.15.1

It works on MacBook Pro M2 with Mac OS Sonoma Version 14.1.1 (23B81).

Really thank you for making the app work again with Mac OS! I couldn't find anything close to it's quality while being OSS.

@jab-ac
Copy link
Author

jab-ac commented Dec 5, 2023

Ah ok, that definitely has something to do with it, when I start a timer on a task that bar fills up. Maybe this has always been there and I just never noticed? Not sure, but obv not related to the new/fix version. So thanks (again)!!

Is this change intentional? Maybe an artifact on my local system? Interested, but not overly concerned, just happy to be able to update to the latest versions. Thanks to all who contributed to the fix, cheers!!

Not that I would be aware of. Maybe it's some change on electrons side of things? SP uses the OSs progresss bar feature, so that might be it. If you create a task with "Some task 30m/1h" and start it, does the bar change?

@jab-ac
Copy link
Author

jab-ac commented Dec 5, 2023

The new release is out! Please let me know if it works for you: https://github.com/johannesjo/super-productivity/releases/tag/v7.15.1

It works on MacBook Pro M2 with Mac OS Sonoma Version 14.1.1 (23B81).

Really thank you for making the app work again with Mac OS! I couldn't find anything close to it's quality while being OSS.

I second this entire comment wholeheartedly!

@pattkrajnik
Copy link

Works as a charm on M1 now :) Thanks

@team-epk
Copy link

team-epk commented Dec 5, 2023

MacBook Air M1/Monterey - up to date and back in business. Thanks so much!

@johannesjo
Copy link
Owner

Great to hear it! Thank you very much everyone and special thanks again to @noname77 !

@noname77
Copy link

sorry I didn't get back earlier, but glad to see others jump in with answers :)

just installed the latest version with brew and happily running, thanks @johannesjo for the release!

and tbh, id say credit goes to @thetric for pointing to the solution in here #2503 (comment) and to Johannes for making it dead simple to build this beauty :)

re the progress bar in the dock, its been there for a while for me, at least since 7.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests