Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular2 d.ts not updated #79

Open
agarciagan opened this issue Mar 1, 2017 · 2 comments
Open

angular2 d.ts not updated #79

agarciagan opened this issue Mar 1, 2017 · 2 comments

Comments

@agarciagan
Copy link

The smoothie.d.ts file is not updated and is giving strange compilation errors on angular2 (module smoothie not found) solvable touching .angular-cli.json file.

The origin of the problem seems to be the d.ts file not being updated and using "declare module "smoothie". The source of the smoothie.d.ts file has an updated version that solves the issue
index.d.ts

@drewnoakes
Copy link
Collaborator

I'm confused where you're seeing declare module "smoothie".

I don't see it in the project's .d.ts file: https://github.com/joewalnes/smoothie/blob/master/smoothie.d.ts

Nor on DefinitelyTyped: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/smoothie/index.d.ts

@agarciagan
Copy link
Author

Hi,
I suppose there is some synchronization error with the npm module. I have just executed
npm install smoothie
And the resulting smoothie.d.ts corresponds to v1.25, while the smoothie.js corresponds to v1.27.

The downloaded smoothie.d.ts starts with the declare module

`// Type definitions for Smoothie Charts 1.25
// Project: https://github.com/joewalnes/smoothie
// Definitions by: Drew Noakes https://drewnoakes.com
// Mike H. Hawley https://github.com/mikehhawley
// Definitions: https://github.com/borisyankov/DefinitelyTyped/smoothie

declare module "smoothie"
{
export interface ITimeSeriesOptions
{
resetBounds?: boolean;
resetBoundsInterval?: number;
}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants