Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: smudging at some fractional devicePixelRatio #151

Open
WofWca opened this issue Dec 9, 2022 · 0 comments · May be fixed by #136
Open

fix: smudging at some fractional devicePixelRatio #151

WofWca opened this issue Dec 9, 2022 · 0 comments · May be fixed by #136

Comments

@WofWca
Copy link
Collaborator

WofWca commented Dec 9, 2022 •
edited

Here's 1.1 DPR (page zoom):

image

As you can see, the lines appear to be of different width/color. It's especially noticeable for 1px-wide lines. The effect is much more visible in motion.

Probably need to look here:

smoothie/smoothie.js

Lines 843 to 845 in cd7a6b5

// Round time down to pixel granularity, so that pixel sample values remain the same,
// just shifted 1px to the left, so motion appears smoother.
time -= time % this.options.millisPerPixel;

@WofWca WofWca linked a pull request Dec 9, 2022 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: chart jumping and wobbling on window.devicePixelRatio !== 1 WofWca/smoothie
1 participant
@WofWca