Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make all lines sharp #134

Merged
merged 2 commits into from Dec 7, 2021
Merged

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Sep 22, 2021

Before:
image

After:
image

Closes #57.
This removes the grid.sharpLines option.

Base branch is #131, so TODO:

@WofWca WofWca force-pushed the sharp-everything branch 2 times, most recently from 7ae5fa7 to e22ba7e Compare September 22, 2021 13:29
@WofWca WofWca mentioned this pull request Oct 17, 2021
@drewnoakes
Copy link
Collaborator

Merged in #139.

@drewnoakes drewnoakes closed this Dec 7, 2021
@WofWca
Copy link
Collaborator Author

WofWca commented Dec 7, 2021

Hey, sorry, I made a commit to this branch after I merged it to #139, where I updated changelog a bit (b80a73a). You can simply merge this branch again, I resolved the conflicts.
But it's not super urgent or important.

@drewnoakes drewnoakes reopened this Dec 7, 2021
@drewnoakes drewnoakes marked this pull request as ready for review December 7, 2021 11:13
@drewnoakes drewnoakes merged commit 2242b87 into joewalnes:master Dec 7, 2021
@WofWca WofWca deleted the sharp-everything branch December 13, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharp lines for charts with step interpolation
2 participants