Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart constantly jumping in 1-2 pixel steps #131

Merged
merged 2 commits into from Dec 7, 2021

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Sep 6, 2021

WIP because it is based on #130, which I hope will get merged, otherwise I'll rebase.

See commit message for more info.
The effect is noticeable on the example pages.

The issue is noticeable at `millisPerPixel` being between ~ 0.5 & 2.0 the size
of `requestAnimationFrame` period. Canvas image update period would be
inconsistent - some would last longer, some less, some would get skipped
altogether.
@drewnoakes
Copy link
Collaborator

#130 has been merged. Let me know when you think this is good to go and I'll get it merged and make a long-overdue release with your changes.

@drewnoakes drewnoakes mentioned this pull request Sep 6, 2021
@WofWca WofWca marked this pull request as ready for review September 7, 2021 00:50
@WofWca
Copy link
Collaborator Author

WofWca commented Sep 7, 2021

Ready.
GitHub still shows the old diff though for some reason, looks like it doesn't get updated when the target branch updates. Looks good in git diff master..fix-jumpiness

@WofWca WofWca changed the base branch from master to linedash September 7, 2021 01:36
@WofWca WofWca changed the base branch from linedash to master September 7, 2021 01:36
@WofWca
Copy link
Collaborator Author

WofWca commented Sep 7, 2021

Fixed by touching target branch

@WofWca WofWca mentioned this pull request Sep 22, 2021
1 task
@WofWca WofWca mentioned this pull request Oct 17, 2021
@drewnoakes drewnoakes merged commit c25368c into joewalnes:master Dec 7, 2021
@WofWca WofWca deleted the fix-jumpiness branch December 13, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants