Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open setup.py as utf-8 in get_requires_python_str #977

Merged
merged 5 commits into from Dec 30, 2021
Merged

open setup.py as utf-8 in get_requires_python_str #977

merged 5 commits into from Dec 30, 2021

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Dec 29, 2021

will close #976

without this, windows can attempt to open this file as Windows-1252

mayeut
mayeut approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the character reproducing the issue in the first test I added.
The test now fails without the fix on Windows.

@mayeut mayeut merged commit e9ef3e9 into pypa:main Dec 30, 2021
@mayeut
Copy link
Member

mayeut commented Dec 30, 2021

Thanks for the contribution @fgregg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@mayeut mayeut mayeut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on windows, setup_py_python_requires attempts to open utf-8 setup.py as Windows-1252 and fails
3 participants
@fgregg @mayeut @henryiii