New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: produce working SDists, check in CI #893
Conversation
recursive-include cibuildwheel *.cfg | ||
recursive-include cibuildwheel *.in | ||
recursive-include cibuildwheel *.py | ||
recursive-include cibuildwheel *.toml | ||
recursive-include cibuildwheel *.txt | ||
recursive-include cibuildwheel *.typed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also could be written this way
recursive-include cibuildwheel *.cfg | |
recursive-include cibuildwheel *.in | |
recursive-include cibuildwheel *.py | |
recursive-include cibuildwheel *.toml | |
recursive-include cibuildwheel *.txt | |
recursive-include cibuildwheel *.typed | |
recursive-include cibuildwheel *.cfg *.in *.py *.toml *.txt *.typed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way seems fine to me, I'm more familiar with the multi-line version so maybe let's go with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I didn't know about check-manifest, handy tool!
recursive-include cibuildwheel *.cfg | ||
recursive-include cibuildwheel *.in | ||
recursive-include cibuildwheel *.py | ||
recursive-include cibuildwheel *.toml | ||
recursive-include cibuildwheel *.txt | ||
recursive-include cibuildwheel *.typed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way seems fine to me, I'm more familiar with the multi-line version so maybe let's go with that
Like every other handy tool: https://scikit-hep.org/developer/style It is setuptools only, so I haven’t been as active in ensuring that it gets added everywhere as I probably should be. |
Fixes issue reported in #892 by ensuring the SDist is not missing files.