ensure tests run on prerelease Pythons #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary overlap in functionality
|
I've pushed a change here to refactor the class hierarchy as there was some unnecessary coupling before. |
|
I'd like to get this out as a patch release I think... as it could be impacting 3.11 testing. |
henryiii
approved these changes
Jun 15, 2022
mayeut
approved these changes
Jun 15, 2022
|
Thank you @nitzmahone and reviewers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1137
This is a pretty naive approach to the fix- not sure if maybe the Python prerelease stuff should just move to another layer in the class hierarchy instead, but this makes things work as expected at least...