New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: remove package_name #113
Conversation
recommended by @YannickJadoul
Thanks a lot, @xanderyzwich! I have a few more remarks to clear up things that should (hopefully) also help fix the final build failures on Travis CI and CircleCI :-) |
Yey, getting close :-) |
No |
@soekah What's a 'No'? |
…ect root directory in __main__.py
It was just an indentation error breaking the build, it seems. Since it's so small, I've quickly fixed it and pushed it to your PR, @xanderyzwich. This should do it (fingers crossed) and allow us to merge your PR :-) |
Due to an unrelated error, the Python 3 test on macOS now fails. However, I've just fixed this in commit 481b1cb Apart from that, all changes have been discussed with @joerick. So since the final diff is quite concise and since I'm happy tests are now succeeding, I'm going to merge this! :-D Thanks, @xanderyzwich! |
thanks, both! |
Removals made per comments in the issue
Closes #102