Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: remove package_name #113

Merged
merged 5 commits into from Nov 29, 2018
Merged

Refactoring: remove package_name #113

merged 5 commits into from Nov 29, 2018

Conversation

xanderyzwich
Copy link
Contributor

Removals made per comments in the issue
Closes #102

cibuildwheel/linux.py Outdated Show resolved Hide resolved
test/06_docker_images/setup.py Show resolved Hide resolved
test/03_before_build/setup.py Show resolved Hide resolved
test/04_build_skip/setup.py Show resolved Hide resolved
test/05_environment/setup.py Show resolved Hide resolved
cibuildwheel/__main__.py Show resolved Hide resolved
@YannickJadoul
Copy link
Member

Thanks a lot, @xanderyzwich!

I have a few more remarks to clear up things that should (hopefully) also help fix the final build failures on Travis CI and CircleCI :-)

@YannickJadoul
Copy link
Member

Yey, getting close :-)
Let's have a quick look to see why the tests are now failing.

@ghost
Copy link

ghost commented Nov 29, 2018

No

@YannickJadoul
Copy link
Member

No

@soekah What's a 'No'?

@YannickJadoul
Copy link
Member

It was just an indentation error breaking the build, it seems. Since it's so small, I've quickly fixed it and pushed it to your PR, @xanderyzwich. This should do it (fingers crossed) and allow us to merge your PR :-)

@YannickJadoul
Copy link
Member

Due to an unrelated error, the Python 3 test on macOS now fails. However, I've just fixed this in commit 481b1cb

Apart from that, all changes have been discussed with @joerick. So since the final diff is quite concise and since I'm happy tests are now succeeding, I'm going to merge this! :-D

Thanks, @xanderyzwich!

@YannickJadoul YannickJadoul merged commit 5adfce9 into pypa:master Nov 29, 2018
@joerick
Copy link
Contributor

joerick commented Nov 30, 2018

thanks, both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants