Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract project as current user on linux #1095

Merged
merged 1 commit into from Apr 26, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Apr 24, 2022

This allows git to work properly, e.g., versioneer/setuptools_scm with latest git versions.
c.f. pypa/manylinux#1309

e.g. for ninja which uses versioneer when built on quay.io/pypa/manylinux2014_x86_64:latest:

  • ninja-0+unknown-py2.py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl without the fix
  • ninja-1.10.2.3.post17.dev0+g3a8b005-py2.py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl with the fix

This allows git to work properly, e.g., `versioneer`/`setuptools_scm` with latest git versions.
c.f. pypa/manylinux#1309
@henryiii
Copy link
Contributor

The downstream projects can fix this too by specifying the git root explicitly, such as in pypa/setuptools_scm#708. But this seems like a good fix, the ownership should not be based on the contents of the tar file.

@henryiii
Copy link
Contributor

This is a fix for main, or for using the latest manylinux manually? I’m assuming older pins in released versions have the older git and are fine?

@mayeut
Copy link
Member Author

mayeut commented Apr 26, 2022

This is a fix for main, or for using the latest manylinux manually? I’m assuming older pins in released versions have the older git and are fine?

Pinned images in main are still using older git and are not affected (will be affected once updates kick-in).
Users that are specifying latest manylinux images or custom images are affected (the report in manylinux repo is a cibuildwheel user using custom image based on manylinux, or mayeut/patchelf-pypi#16 with a custom image which is now failing).

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone curious:

     --no-same-owner
             (x mode only) Do not extract owner and group IDs.  This is the
             reverse of --same-owner and the default behavior if tar is run as
             non-root.

It seems to me very reasonable ignore ownership here 👍 I guess the UIDs don't even match up between the host and container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants