Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add manylinux_2_28 support #1026

Merged
merged 1 commit into from Jun 17, 2022
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 13, 2022

Draft for manylinux_2_28 support
c.f. pypa/manylinux#1282

The plan for this draft is:

  • 1. basic addition of the manylinux_2_28 support using Proof-Of-Concept images
  • 2. use these images as default ones (to be reverted) in order to really test these new images
  • 3. update based on POC image updates
  • 4. switch to final images
  • 5. add documentation
  • 6. revert the default image to manylinux2014
  • 7. ready for review

test/test_docker_images.py Outdated Show resolved Hide resolved
@EwoutH
Copy link

EwoutH commented May 25, 2022

manylinux_2_28 support in cibuildwheel would be amazing, so thanks for this effort!

@EwoutH
Copy link

EwoutH commented May 30, 2022

pypa/manylinux#1282 is merged, there is now an official manylinux_2_28 image!

Docker images are on https://quay.io/organization/pypa/.

@EwoutH
Copy link

EwoutH commented Jun 2, 2022

@mayeut mayeut force-pushed the manylinux_2_28 branch 5 times, most recently from e0352c4 to d849a02 Compare June 4, 2022 09:31
@mayeut mayeut marked this pull request as ready for review June 4, 2022 09:31
@mayeut mayeut force-pushed the manylinux_2_28 branch 3 times, most recently from d03df9a to 2e5ee3d Compare June 6, 2022 13:56
@mayeut mayeut mentioned this pull request Jun 6, 2022
@EwoutH
Copy link

EwoutH commented Jun 9, 2022

What's still needed to merge this PR?

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you @mayeut

@joerick joerick merged commit 133197e into pypa:main Jun 17, 2022
@mayeut mayeut deleted the manylinux_2_28 branch June 17, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants