Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private extension packs and private extension dependencies #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lachaib
Copy link
Contributor

@lachaib lachaib commented Sep 29, 2022

Fixes #30

I had to shake some rust off my VS Code extension development, but it seems to be doing the job, I'd be glad to get someone to test it

@colas31
Copy link
Contributor

colas31 commented Oct 12, 2022

Hello @lachaib ;)
Hope you are good.

I can run some tests if needed.
Tell me what I should do to test this PR properly.

@lachaib
Copy link
Contributor Author

lachaib commented Oct 13, 2022

Hi @colas31 ,
To test this, you may pull the branch, build the extension and install extension from the built vsix.

  • I'm assuming you have private registries already available, the first thing that would come to my mind would be to assert there is no regression, i.e. you are able to install or update an extension as you did before.
  • Secondly, it would be nice to create an extension pack with one or more of the private extensions you have in your registry, publish it to your private registry and try to install it (with the private extensions it should pull not already installed), and check that install works just fine.
  • And last, there was also an opportunity to use private registries as cache for extensions from marketplace (for people behind strict firewalls), so you may pull some extensions and extension packs (e.g. python) from marketplace to the private registry and see that when installing them from the private registry the pack and all its dependencies are pulled together from the registry.

That's what I'd do if I was still in my previous company and had a private extension registry.
Thanks for your help

@kumar121193
Copy link

@lachaib @colas31 Any update on this?

@lachaib
Copy link
Contributor Author

lachaib commented Dec 14, 2022

Not on my side, I'm still waiting feedback from someone eager to test, if you want to test it yourself I explained the procedure.

@colas31
Copy link
Contributor

colas31 commented Dec 21, 2022

Unfortunately I didn't get time to test. And I just changed my position job.
It will be more difficult for me to perform the test.

@kuenzign
Copy link

kuenzign commented Sep 6, 2023

Has there been any update on this? Having private extension packs would be very beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support private extension packs and private extension dependencies
4 participants