Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private extension packs and private extension dependencies #30

Open
lachaib opened this issue Nov 20, 2020 · 7 comments · May be fixed by #75
Open

Support private extension packs and private extension dependencies #30

lachaib opened this issue Nov 20, 2020 · 7 comments · May be fixed by #75
Labels
enhancement New feature or request

Comments

@lachaib
Copy link
Contributor

lachaib commented Nov 20, 2020

Hello,

While trying to bundle several private extensions along as extensionPack or extensionDependencies, I discovered that it's not possible to install private extensions through them.
(Btw, while looking at the code I found a typo)

From what I read in installExtensionByPackage, what would need to be done is to extract from manifest for fields extensionPack and extensionDependencies, and for each element in the lists, try to see if they can be found in any registry, in which case they should be also be installed by installExtensionById. If not found in registry, call workbench.extensions.installExtension command as done currently.

This would also be a good opportunity for private registries to be a cache for large extensions.

Thanks

@joelspadin-garmin joelspadin-garmin added the enhancement New feature or request label Nov 20, 2020
@kumar121193
Copy link

@joelspadin-garmin This would be a beneficial addition to the manager. In my company, we have multiple private extensions and want to create a private extension pack that bundles private and public extensions. As @lachaib is suggesting, the code changes would be to read through the extensionPack and extensionDependencies before executing workbench.extensions.installExtension, and installing any private extensions available in the registry.

@kumar121193
Copy link

@joelspadin-garmin Please let me know if this enhancement can be added. I am happy to contribute if needed.

@joelspadin-garmin
Copy link
Owner

Sorry for the late response. Yes, this does sound like something that could be useful. I don't have time to implement it though.

@lachaib
Copy link
Contributor Author

lachaib commented Sep 29, 2022

I can make the contribution but I've changed company since and won't be able to test it.
Anyone who'd be eager to test?

lachaib added a commit to lachaib/vscode-private-extension-manager that referenced this issue Sep 29, 2022
@kumar121193
Copy link

@lachaib @joelspadin-garmin Any update on this?

@josiezhan
Copy link

I can make the contribution but I've changed company since and won't be able to test it. Anyone who'd be eager to test?

I've tested it.It's useful。

@lachaib
Copy link
Contributor Author

lachaib commented Feb 23, 2023

I can make the contribution but I've changed company since and won't be able to test it. Anyone who'd be eager to test?

I've tested it.It's useful。

Thanks @KINGZJS
Can you mention your test in the pull request as well? Now we'll need @joelspadin-garmin to merge and release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants