-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private extension packs and private extension dependencies #30
Comments
@joelspadin-garmin This would be a beneficial addition to the manager. In my company, we have multiple private extensions and want to create a private extension pack that bundles private and public extensions. As @lachaib is suggesting, the code changes would be to read through the |
@joelspadin-garmin Please let me know if this enhancement can be added. I am happy to contribute if needed. |
Sorry for the late response. Yes, this does sound like something that could be useful. I don't have time to implement it though. |
I can make the contribution but I've changed company since and won't be able to test it. |
@lachaib @joelspadin-garmin Any update on this? |
I've tested it.It's useful。 |
Thanks @KINGZJS |
Hello,
While trying to bundle several private extensions along as extensionPack or extensionDependencies, I discovered that it's not possible to install private extensions through them.
(Btw, while looking at the code I found a typo)
From what I read in installExtensionByPackage, what would need to be done is to extract from manifest for fields
extensionPack
andextensionDependencies
, and for each element in the lists, try to see if they can be found in any registry, in which case they should be also be installed by installExtensionById. If not found in registry, callworkbench.extensions.installExtension
command as done currently.This would also be a good opportunity for private registries to be a cache for large extensions.
Thanks
The text was updated successfully, but these errors were encountered: