Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change precedence of assumption classes #1983

Merged
merged 1 commit into from Aug 28, 2020
Merged

Change precedence of assumption classes #1983

merged 1 commit into from Aug 28, 2020

Conversation

scordio
Copy link
Member

@scordio scordio commented Aug 27, 2020

Related to testng-team/testng#2352.

Check List:

@scordio scordio added this to the 3.17.1 milestone Aug 27, 2020
Copy link
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @scordio, looks good, just some minor comments

@joel-costigliola joel-costigliola added the type: breaking change A change that modifies the behavior of an existing feature label Aug 28, 2020
In order of priority:
* org.opentest4j.TestAbortedException
* org.testng.SkipException
* org.junit.AssumptionViolatedException
@scordio
Copy link
Member Author

scordio commented Aug 28, 2020

@joel-costigliola PR ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change A change that modifies the behavior of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assumptions.assumeThat incompatible with TestNG 7.1.1+
2 participants