Wrong assertion in EqualsHashCodeContractAssert

[ghostd]

Hi,

I read the class EqualsHashCodeContractAssert, and since equals returns a boolean, i think

public static void assertIsNotEqualToNull(Object obj) {
    assertThat(obj.equals(null)).isNull();
}

should be

public static void assertIsNotEqualToNull(Object obj) {
    assertThat(obj.equals(null)).isFalse();
}

If you didn't spot the bug, i guess this is dead code.

Regards

[ghostd]

By the way, did you consider expose those assertions in the public API to check the equals contract?

[joel-costigliola]

Good catch! The code is dead code indeed, it was written in Fest Assert which AssertJ is a fork of.

I think it is better to use https://jqno.nl/equalsverifier/ to test equals and hashcode, no plan in the roadmap to support this.

[ghostd]

Ok, thanks for the pointer.