Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test the future loky-3.3.0 branch #1338

Merged
merged 12 commits into from Sep 16, 2022
Merged

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Sep 15, 2022

Let see if the fixed process management of loky make the joblib CI more stable.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 94.00% // Head: 93.88% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (eaafe22) compared to base (067ed4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
- Coverage   94.00%   93.88%   -0.13%     
==========================================
  Files          52       52              
  Lines        7294     7293       -1     
==========================================
- Hits         6857     6847      -10     
- Misses        437      446       +9     
Impacted Files Coverage Δ
joblib/test/test_memmapping.py 99.23% <100.00%> (-0.01%) ⬇️
joblib/test/testutils.py 50.00% <0.00%> (-50.00%) ⬇️
joblib/_parallel_backends.py 93.01% <0.00%> (-1.84%) ⬇️
joblib/memory.py 95.25% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel
Copy link
Contributor Author

ogrisel commented Sep 15, 2022

I pushed the second Trigger CI commit too early and wasted some CI time...

@ogrisel
Copy link
Contributor Author

ogrisel commented Sep 15, 2022

The flaky test_child_raises_parent_exits_cleanly observed above is being XFAILed in #1339 since I don't see an easy way to reproduce the problem locally to debug it. It's not impacting the default backend so I don't think fixing it is so high priority anyway.

@ogrisel
Copy link
Contributor Author

ogrisel commented Sep 15, 2022

Hum unfortunately, the new loky does not solve all the problems. We again got a low level crash on a macos run:

[...]
joblib/test/test_memmapping.py::test_multithreaded_parallel_termination_resource_tracker_silent PASSED [ 48%]
joblib/test/test_memmapping.py::test_many_parallel_calls_on_same_object[multiprocessing] continuous_integration/run_tests.sh: line 25:  6662 Terminated: 15          pytest joblib -vl --timeout=120 --junitxml="${JUNITXML}"
The STDIO streams did not close within 10 seconds of the exit event from process '/bin/bash'. This may indicate a child process inherited the STDIO streams and has not yet exited.

@ogrisel ogrisel merged commit cea26ff into joblib:master Sep 16, 2022
@ogrisel ogrisel deleted the loky-3.3.0 branch September 16, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant