Avoid Memory collision between notebooks with same function name #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
- Coverage 94.52% 93.90% -0.62%
==========================================
Files 47 47
Lines 6955 6956 +1
==========================================
- Hits 6574 6532 -42
- Misses 381 424 +43
Continue to review full report at Codecov.
|
NicolasHug
commented
Aug 24, 2020
| @@ -128,10 +128,20 @@ def get_func_name(func, resolv_alias=True, win_characters=True): | |||
| # mangling of full path to filename | |||
| parts = filename.split(os.sep) | |||
| if parts[-1].startswith('<ipython-input'): | |||
| # function is defined in an IPython session. The filename | |||
| # will change with every new kernel instance. This hack | |||
There was a problem hiding this comment.
BTW, I believe the comment is incorrect: the filename doesn't change with new kernel instances. It changes because of N (see new comments)
ogrisel
approved these changes
Oct 2, 2020
|
Thanks for the fix. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096
This PR changes the cache directory from
[...]/joblib-__ipython-input__/<TheFunctionName>/to
[...]/joblib-<ipython-input-XYZ>/<TheFunctionName>/,where
XYZcomes fromco_filenameand is a hash of the function.Ideally this should probably use the
.ipynbfilename but I don't think we can retrieve it easily, and it wouldn't work for pure IPython sessions.I'm not sure how to test this?