Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT cloudpickle 1.5.0 #1090

Merged
merged 3 commits into from
Jul 24, 2020
Merged

MAINT cloudpickle 1.5.0 #1090

merged 3 commits into from
Jul 24, 2020

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Jul 24, 2020

Closes #1089

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1090 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   94.52%   94.28%   -0.25%     
==========================================
  Files          47       47              
  Lines        6910     6910              
==========================================
- Hits         6532     6515      -17     
- Misses        378      395      +17     
Impacted Files Coverage Δ
joblib/test/test_store_backends.py 91.42% <0.00%> (-5.72%) ⬇️
joblib/_parallel_backends.py 94.92% <0.00%> (-1.57%) ⬇️
joblib/test/test_parallel.py 95.62% <0.00%> (-1.54%) ⬇️
joblib/parallel.py 97.00% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8c8cf...35170ea. Read the comment docs.

@ogrisel
Copy link
Contributor Author

ogrisel commented Jul 24, 2020

Note sure what is causing the segfaults when running the sklearn tests but this is not related to the cloudpickle upgrade as I can reproduce it in #1090. Merging.

@ogrisel ogrisel merged commit e6977d1 into joblib:master Jul 24, 2020
@ogrisel ogrisel deleted the cloudpickle-1.5.0 branch July 24, 2020 12:17
tomMoral pushed a commit to cottrell/joblib that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Cloudpickle to 1.5.0
1 participant