forked from ember-cli/eslint-plugin-ember
-
Notifications
You must be signed in to change notification settings - Fork 0
/
no-tracked-properties-from-args.js
61 lines (53 loc) · 1.95 KB
/
no-tracked-properties-from-args.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
'use strict';
const { getImportIdentifier } = require('../utils/import');
const { isClassPropertyOrPropertyDefinitionWithDecorator } = require('../utils/decorators');
const ERROR_MESSAGE =
'Do not use this.args to create @tracked properties as this will not be updated if the args change. Instead use a getter.';
function visitClassPropertyOrPropertyDefinition(node, context, trackedImportName) {
const hasTrackedDecorator =
node.decorators?.length > 0 &&
isClassPropertyOrPropertyDefinitionWithDecorator(node, trackedImportName);
const hasThisArgsValue =
node.value.object?.type === 'MemberExpression' &&
node.value.object?.object.type === 'ThisExpression' &&
node.value.object?.property.name === 'args';
if (hasTrackedDecorator && hasThisArgsValue) {
context.report({ node, messageId: 'main' });
}
}
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow creating @tracked properties from this.args',
category: 'Ember Octane',
recommended: false,
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-tracked-properties-from-args.md',
},
fixable: null,
schema: [],
messages: {
main: ERROR_MESSAGE,
},
},
create(context) {
let trackedImportName;
return {
ImportDeclaration(node) {
if (node.source.value === '@glimmer/tracking') {
trackedImportName = getImportIdentifier(node, '@glimmer/tracking', 'tracked');
}
},
ClassProperty(node) {
visitClassPropertyOrPropertyDefinition(node, context, trackedImportName);
},
PropertyDefinition(node) {
visitClassPropertyOrPropertyDefinition(node, context, trackedImportName);
},
};
},
};