Remove test/ from bundled gem

[parkr]

Hey folks,

I noticed that this gem is 2.6 MB, 2.5 of which comes from test/data/large_dataset.json. Is it necessary to ship the test data with this gem? Perhaps we could get away with just:

• lib/
• crack.gemspec
• History
• LICENSE
• README.md

What do you think? /cc @bf4

[parkr]

[bf4]

Nope, no need to ship tests. Rubygems hasn't supported executing them for ages and I think there's a general pattern of removing them from built gems. You up for a PR?

[parkr]

Well, it looks like I was beaten to it – in 2018! Crack v0.4.3 (pictured above) included the test data, but v0.4.4 (which I just upgraded to), does not.

Thank you for the quick reply, @bf4, and for being cool with the proposal. Sorry for not checking on the latest version! 🤦

[bf4]

Lol

…

On Fri, Oct 30, 2020, 8:25 AM Parker Moore ***@***.***> wrote: Well, it looks like I was beaten to it – in 2018! <#61> Crack v0.4.3 (pictured above) included the test data, but v0.4.4 (which I just upgraded to), does not. Thank you for the quick reply, @bf4 <https://github.com/bf4>, and for being cool with the proposal. Sorry for not checking on the latest version! 🤦 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABC4QWNOZVLHL6U2L3BFBDSNK5EZANCNFSM4TEFZ4JQ> .