Exclude tests (and fixtures) from bundled gem #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voxik
added a commit
to voxik/crack
that referenced
this pull request
Jan 8, 2021
PR jnunemaker#61 removed not only test files, but also useful files, such as LICENSE file. This file is demanded by Linux distros such as Fedora.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First up, thanks for
crack.Currently, the bundled gem includes all of cracks tests and fixtures. That makes it quite large (564Kb). There's no need to include those tests and fixtures - this PR removes them from the gemspec (note that the
test_filesattribute is now deprecated, so I've removed that too). The slimmed down gem is 12KB - a 98% size reduction. 馃帀