Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability in the future dependency #75

Closed
romanek-adam-b2c2 opened this issue Jan 5, 2023 · 5 comments
Closed

Security vulnerability in the future dependency #75

romanek-adam-b2c2 opened this issue Jan 5, 2023 · 5 comments

Comments

@romanek-adam-b2c2
Copy link

  • django-json-widget version: 1.1.1
  • Django version: 3.2
  • Python version: 3.10
  • Operating System: Ubuntu

Description

This library depends on the future package which is not maintained, but contains a high-severity vulnerability: GHSA-v3c5-jqr6-7qm8

Please drop the dependency on this package if possible.

@whardeman
Copy link

whardeman commented Jan 5, 2023

Agreed. Makes these others all the more relevant...

#65
#72

Otherwise, I'll be forced to fork this repo until there are more folks who can keep it up to date.

@ashokdelphia
Copy link
Contributor

I agree that stopping using future is worthwhile (see #65), but I don't think that vulnerability is reachable in practice from how it is used here. The troublesome regular expression is in the cookie-handling part of the library, which I believe isn't invoked at all here.

I think it's worth dropping as part of no longer supporting very old versions of Django and Python, as that will typically involve using libraries that are practically unmaintained.

@whardeman
Copy link

@ashokdelphia Thank you for your insight on this! I hadn't looked deeply until now and I agree, it's not a showstopper here.

Most folks are probably (like me) just seeing security vulnerability warnings and scrambling to keep their dependencies clean. In our case, future was only used by two dependencies (the other having already dropped it in a recent release, so just needed to upgrade).

Still hopeful that @jmrivas86 can add a few more folks to help maintain this. It's a good one!

@kennell
Copy link

kennell commented Apr 15, 2023

@jmrivas86 Can we get this merged please?

@jmrivas86
Copy link
Owner

Fixed in pifantastic#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants