Use humanize.intcomma to format years in time module
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 97.08% 97.10% +0.02%
==========================================
Files 10 10
Lines 685 690 +5
==========================================
+ Hits 665 670 +5
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Please could you add tests? |
|
Yes. Added. |
hugovk
changed the title
|
Thanks! |
hugovk
changed the title
humanize.intcomma to format years in time module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #245
Presently, it is hard to read very long times because the largest time denomination that
humanizeincludes is years. In this pull request,humanize.intcomma()is now used to format the number of years returned bynaturaldelta()andprecisedelta().Alternate approaches considered include:
millenniadenomination, but this would require all translations to be updated.{:n}format specifier along with the standardlocalemodule, but locale has inconsistent behavior across platforms andhumanizealready uses an internal localization module.