Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of \r #59

Closed
wants to merge 1 commit into from
Closed

Fixed handling of \r #59

wants to merge 1 commit into from

Conversation

SamMousa
Copy link

Fixes #58

@GrahamCampbell
Copy link

Looks good. I've added your tests to the PHP implementation, and it is passing on them (as expected).

@SamMousa
Copy link
Author

Are you planning to maintain your fork? Or still hoping to get this merged here at some point?

@GrahamCampbell
Copy link

I'm not talking about my fork. I'm talking about https://github.com/jmespath/jmespath.php. :)

@GrahamCampbell
Copy link

By added, I should have said "it will be added in the next few minutes". I've not yet merged the changes. ;)

@SamMousa
Copy link
Author

Ah, didn't see that correctly (and didn't realize you could merge into this repo :))

@GrahamCampbell
Copy link

I am helping maintain the PHP implementation only, at the moment. :)

@SamMousa SamMousa closed this by deleting the head repository Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace character handling
2 participants