Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit existing jmespath functions for reflection usage #21

Open
jamesls opened this issue Feb 2, 2016 · 2 comments
Open

Audit existing jmespath functions for reflection usage #21

jamesls opened this issue Feb 2, 2016 · 2 comments

Comments

@jamesls
Copy link
Member

jamesls commented Feb 2, 2016

We need to avoid checks for empty interfaces and map[string]interface{} and instead use reflection. This has been fixed in interpreter.go but functions.go needs the same treatment.

I'd also like to investigate adding autogen'd tests using structs from the compliance tests to verify we don't miss anything.

Related: #14

@tve
Copy link

tve commented May 18, 2016

I'm new to this jmespath implementation, but I was hoping that it didn't use reflection given the rather steep performance penalty. Are you basically moving away from type assertions to reflection across the board or only in very narrow cases?

@skyzyx
Copy link

skyzyx commented Apr 1, 2020

This is 4 years old. What's going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants