Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit in locales #349

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Add ability to edit in locales #349

wants to merge 18 commits into from

Conversation

jmalcic
Copy link
Owner

@jmalcic jmalcic commented Apr 27, 2021

This PR adds the ability to actually enter translated data when editing records.

@jmalcic jmalcic linked an issue Apr 27, 2021 that may be closed by this pull request
@jmalcic jmalcic requested a review from louis-vs April 27, 2021 13:12
@jmalcic jmalcic enabled auto-merge April 27, 2021 13:12
@louis-vs
Copy link
Collaborator

Conference parts aren't saved properly in their respective locales. If I edit the text part in English, it doesn't save. If I edit the part in British English, it saves for both locales - so if I now view the English version I get what I just saved for BE. Further, whenever I submit the conference form, I get Unpermitted parameter: :_destroy which might be related.

The events repeater within the conference works perfectly though, as does every other page as far as I can tell!

@jmalcic
Copy link
Owner Author

jmalcic commented Apr 27, 2021

Thanks for the feedback, will investigate and extend the system tests

@jmalcic jmalcic marked this pull request as draft April 27, 2021 19:13
auto-merge was automatically disabled April 27, 2021 19:13

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow editing in locales
2 participants