Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check C++ code formatting in CI #109

Open
MikailBag opened this issue Nov 26, 2019 · 2 comments
Open

Check C++ code formatting in CI #109

MikailBag opened this issue Nov 26, 2019 · 2 comments
Labels
C-infra CI configs, devtool and other stuff simplifying development good first issue Good for newcomers T-enhancement New feature or request

Comments

@MikailBag
Copy link
Member

#108 added clang-format config.
As with rustfmt, we should enforce it via CI.
It is not trivial due to actions/runner-images#28.
Possible strategies:

  • Wait until Github fixes VM images
  • Wait until Actions can use images from github package registry for docker
  • Use alternative clang-format installation way.
@MikailBag MikailBag added T-enhancement New feature or request C-infra CI configs, devtool and other stuff simplifying development labels Nov 26, 2019
@p4vook
Copy link
Member

p4vook commented Mar 21, 2020

Any updates on this?

@MikailBag
Copy link
Member Author

Still waiting for implementation

@MikailBag MikailBag added the good first issue Good for newcomers label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-infra CI configs, devtool and other stuff simplifying development good first issue Good for newcomers T-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikailBag @p4vook