Copy un-exported struct fields in DeepCopy #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
遇到了同样的问题。求问解决同问题的 PR 已经有了 3 个。 |
joshhardy
force-pushed
the
fix-deepcopy-unexported-fields
branch
from
e3a93ac
to
b369e8a
Compare
|
@jinzhu I rebased this PR on your recent updates (https://github.com/jinzhu/copier/releases/tag/v0.3.4). |
|
@jinzhu could you please make a new release to include this fix? Since it's related to a lot of issues, it would help some of us 😄 Thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues #97 and #98.
Like PR #105, it is not specific to
time.Time, but resolves the issue by ensuring un-exported fields of a struct are copied, even whenDeepCopy: true.The idea was inspired by PR #105, but the structure is quite different.
PR #105 did not resolve the issue I faced or make tests pass. This PR does both.
I retained the tests added by PRs #103 and #105 and added a few more cases that exhibit the specific issue I faced.