Skip to content

refactor(types): allow chaining multiple convert_ functions #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 25, 2021

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Oct 25, 2021
@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1439, delta to last 2 avg.: +35%
  • 🐎🐎🐎🐎 query QPS at 68, delta to last 2 avg.: +34%
  • 🐎🐎🐎🐎 dam extend QPS at 53978, delta to last 2 avg.: +49%
  • 🐎🐎🐎🐎 avg flow time within 1.0815 seconds, delta to last 2 avg.: -26%
  • 🐢🐢 import jina within 0.4587 seconds, delta to last 2 avg.: -7%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1439 68 53978 1.0815 0.4587
2.1.11 1064 51 35243 1.7236 0.5041
2.1.10 1064 49 37054 1.2081 0.49

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #3772 (9981749) into master (136ddec) will increase coverage by 1.13%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3772      +/-   ##
==========================================
+ Coverage   88.49%   89.62%   +1.13%     
==========================================
  Files         156      156              
  Lines       11942    11955      +13     
==========================================
+ Hits        10568    10715     +147     
+ Misses       1374     1240     -134     
Flag Coverage Δ
daemon 44.90% <40.74%> (-0.06%) ⬇️
jina 88.54% <92.59%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/converters.py 82.38% <92.59%> (+0.79%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 85.08% <0.00%> (+1.75%) ⬆️
jina/clients/mixin.py 100.00% <0.00%> (+2.50%) ⬆️
jina/clients/base/helper.py 88.70% <0.00%> (+3.22%) ⬆️
jina/flow/base.py 92.39% <0.00%> (+5.74%) ⬆️
jina/peapods/pods/k8slib/kubernetes_deployment.py 95.83% <0.00%> (+11.11%) ⬆️
jina/peapods/stream/client.py 90.90% <0.00%> (+12.12%) ⬆️
jina/peapods/pods/k8s.py 81.26% <0.00%> (+18.73%) ⬆️
jina/peapods/pods/k8slib/kubernetes_tools.py 94.66% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136ddec...9981749. Read the comment docs.

@hanxiao hanxiao merged commit 77255ae into master Oct 25, 2021
@hanxiao hanxiao deleted the refactor-converter-chain branch October 25, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant