Skip to content

feat: pass native in container runtime docker #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2021
Merged

feat: pass native in container runtime docker #3200

merged 2 commits into from
Aug 18, 2021

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Aug 18, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner August 18, 2021 06:57
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #3200 (9351df7) into master (befb7cd) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3200      +/-   ##
==========================================
+ Coverage   90.04%   90.25%   +0.20%     
==========================================
  Files         147      147              
  Lines       10317    10318       +1     
==========================================
+ Hits         9290     9312      +22     
+ Misses       1027     1006      -21     
Flag Coverage Δ
daemon 42.89% <0.00%> (+0.04%) ⬆️
jina 90.24% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/container/__init__.py 84.61% <100.00%> (+0.09%) ⬆️
jina/helper.py 80.03% <0.00%> (+0.37%) ⬆️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/peapods/pods/__init__.py 91.18% <0.00%> (+4.55%) ⬆️
jina/clients/base/grpc.py 70.21% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befb7cd...9351df7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 18, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1376, delta to last 2 avg.: +1%
  • 🐎🐎🐎🐎 query QPS at 39, delta to last 2 avg.: +49%
  • 🐎🐎🐎🐎 dam extend QPS at 45281, delta to last 2 avg.: -1%
  • 🐎🐎🐎🐎 avg flow time within 1.7135 seconds, delta to last 2 avg.: +26%
  • 🐢🐢 import jina within 0.3415 seconds, delta to last 2 avg.: -7%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1376 39 45281 1.7135 0.3415
2.0.18 1321 25 45985 1.376 0.3731
2.0.17 1397 26 46060 1.3403 0.3665

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Aug 18, 2021
@JoanFM JoanFM requested review from hanxiao and nan-wang August 18, 2021 09:37
@hanxiao hanxiao merged commit 53e4607 into master Aug 18, 2021
@hanxiao hanxiao deleted the 3199-ticket branch August 18, 2021 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --native args to Args passed in ContainerRuntime to the docker client
2 participants