Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): 💥 change zed_runtime to executor --native #3196

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Aug 17, 2021

jina zed_runtime is now jina executor --native

@hanxiao hanxiao requested a review from a team as a code owner August 17, 2021 16:00
@github-actions
Copy link

github-actions bot commented Aug 17, 2021

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you all sign our Contributor License Agreement. You can sign it by commenting in format below.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@hanxiao
@jina-bot

@github-actions github-actions bot added size/M area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Aug 17, 2021
@hanxiao
Copy link
Member Author

hanxiao commented Aug 17, 2021

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Aug 17, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1422, delta to last 2 avg.: -6%
  • 🐎🐎🐎🐎 query QPS at 43, delta to last 2 avg.: +41%
  • 🐎🐎🐎🐎 dam extend QPS at 54765, delta to last 2 avg.: +0%
  • 🐎🐎🐎🐎 avg flow time within 1.7959 seconds, delta to last 2 avg.: +12%
  • 🐎🐎 import jina within 0.3664 seconds, delta to last 2 avg.: +10%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1422 43 54765 1.7959 0.3664
2.0.18 1336 25 44186 1.9909 0.3621
2.0.17 1712 35 65044 1.2015 0.2988

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #3196 (d4752b7) into master (b32a0a5) will increase coverage by 9.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3196      +/-   ##
==========================================
+ Coverage   80.25%   90.09%   +9.83%     
==========================================
  Files         147      147              
  Lines       10298    10299       +1     
==========================================
+ Hits         8265     9279    +1014     
+ Misses       2033     1020    -1013     
Flag Coverage Δ
daemon 42.79% <50.00%> (+<0.01%) ⬆️
jina 90.08% <100.00%> (+9.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.02% <ø> (ø)
jina/parsers/peapods/pea.py 100.00% <ø> (ø)
jina/parsers/__init__.py 97.82% <100.00%> (ø)
jina/parsers/peapods/runtimes/zed.py 100.00% <100.00%> (ø)
jina/jaml/helper.py 85.00% <0.00%> (+0.83%) ⬆️
jina/types/routing/table.py 93.80% <0.00%> (+0.88%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 92.64% <0.00%> (+1.47%) ⬆️
jina/parsers/helloworld.py 96.22% <0.00%> (+1.88%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+2.42%) ⬆️
jina/types/ndarray/dense/numpy.py 100.00% <0.00%> (+2.43%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32a0a5...d4752b7. Read the comment docs.

@hanxiao hanxiao merged commit c2eca9f into master Aug 17, 2021
@hanxiao hanxiao deleted the feat-add-bc-emoji branch August 17, 2021 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/flow size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants