Skip to content

feat: enabled workflows for external contributors #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

maateen
Copy link
Contributor

@maateen maateen commented Aug 17, 2021

Changes:

  • feat: changed pull_request_target to pull_request

Signed-off-by: Maksudur Rahman Maateen <maateen@jina.ai>
@maateen maateen requested a review from hanxiao as a code owner August 17, 2021 10:58
@github-actions
Copy link

github-actions bot commented Aug 17, 2021

Jina CLA check ✅ All Contributors have signed the CLA.

@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Aug 17, 2021
@maateen
Copy link
Contributor Author

maateen commented Aug 17, 2021

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #3189 (5ecd541) into master (6403c4b) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
+ Coverage   90.07%   90.16%   +0.09%     
==========================================
  Files         147      147              
  Lines       10274    10274              
==========================================
+ Hits         9254     9264      +10     
+ Misses       1020     1010      -10     
Flag Coverage Δ
daemon 42.77% <ø> (ø)
jina 90.15% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/zmq/zed.py 94.35% <0.00%> (+0.51%) ⬆️
jina/peapods/pods/compound.py 91.78% <0.00%> (+1.36%) ⬆️
jina/peapods/peas/__init__.py 90.47% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6403c4b...5ecd541. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1398, delta to last 2 avg.: +0%
  • 🐎🐎🐎🐎 query QPS at 38, delta to last 2 avg.: +35%
  • 🐎🐎🐎🐎 dam extend QPS at 42443, delta to last 2 avg.: -12%
  • 🐎🐎🐎🐎 avg flow time within 1.6537 seconds, delta to last 2 avg.: -5%
  • 😶 import jina within 0.3571 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1398 38 42443 1.6537 0.3571
2.0.18 1477 31 56973 1.6307 0.3499
2.0.17 1304 25 40314 1.8779 0.3645

Backed by latency-tracking. Further commits will update this comment.

@CatStark CatStark linked an issue Aug 17, 2021 that may be closed by this pull request
@hanxiao hanxiao merged commit b32a0a5 into master Aug 17, 2021
@hanxiao hanxiao deleted the feat-enable-workflows-for-external-contributors branch August 17, 2021 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable workflows for external contributors
2 participants