Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EQ effect for AudioSegment #492

Merged
merged 24 commits into from Mar 6, 2021

Conversation

anubhav-narayan
Copy link
Contributor

No description provided.

This was referenced Jun 15, 2020
@jiaaro
Copy link
Owner

jiaaro commented Jun 16, 2020

thanks, this is a useful and long-overdue feature.

Would you mind making a few aesthetic changes?

  • Removing all the extraneous pass statements
  • Add spaces around the assignments (e.g., x = 1 instead of x=1 ) and after the commas in argument lists (e.g., _eq(a, b, c))
  • Use 4 space indentation

pydub/scipy_effects.py Outdated Show resolved Hide resolved
@anubhav-narayan
Copy link
Contributor Author

anubhav-narayan commented Jun 16, 2020

I was thinking if I could create a module/library which has tools exclusively for musical applications using pydub and since I have no experience of making a python library could you help me with that?
Please!

@jiaaro
Copy link
Owner

jiaaro commented Aug 20, 2020

is #463 included in this PR?

@anubhav-narayan
Copy link
Contributor Author

Yes it does.

@jiaaro jiaaro changed the title Anubhav narayan eq patch 1 Add EQ effect for AudioSegment Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants