Expose maxPaddingWidth in OutputSettings keeping default as 30 #1655
+107
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1653
In order to get my fork up and going, I updated github actions here. I removed jdk 16, added jdk 18-ea, and moved to zulu distribution as temurin does not have 18-ea.
For this change, I added a changelog, added some clarification to 'memoised' padding, deprecated original padding call by having it call newer one with exposed maxPaddingWidth, skipped the min check with -1, and finally called the new one. In an attempt to better understand 'memoised' logic, I actually added more tests than necessary to the existing one for clarity purposes on how that method behaves.
The overall change though tripped up the japicmp plugin. It kept saying the method had been removed. If I removed the deprecation markings I added, it was happy. So I think that plugin only really works against deprecations from prior version. I tried a few different ways to make that work and finally gave up so I just added the class to ignore for the time being. I believe that is a bug in their plugin and that deprecation is important if anyone is otherwise externally using that method since it directs them on what to update.
One other thing, on my fork, github no longer auto turns on actions so I had to get that working so I hunted for some basic items to get it going. I noticed that jetty-servlet was not updated. That is odd given dependabot usage and the other module from jetty was updated so I bumped it up.
Obviously this has more than what I should have for a new pull request. For purposes of review, please use this. If you do need me to then rebase and only send up direct change portions, no problem, I can rebase as necessary.
Thanks,
Jeremy