Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes valid in html when converting #1648

Merged
merged 4 commits into from Oct 6, 2021
Merged

Allow attributes valid in html when converting #1648

merged 4 commits into from Oct 6, 2021

Conversation

jairamc
Copy link
Contributor

@jairamc jairamc commented Sep 29, 2021

When parsing and converting an html document, the "syntax" was hard-coded to xml. This PR checks the document type of the output document and uses that to determine which attributes are valid.

Changes for #1647

When parsing and converting an html document, the "syntax" was hard-coded to xml. This PR checks the document type of the output document and uses that to determine which attributes are valid.
Jairam Chandar and others added 3 commits October 5, 2021 13:53
@jhy jhy merged commit 6b1fbb5 into jhy:master Oct 6, 2021
@jhy
Copy link
Owner

jhy commented Oct 6, 2021

Thanks! I updated the commit a little to preserve the current public constructor of the W3CBuilder, to maintain backcompat. And to reuse the existing ownerDocument scan up, and to add a negative (XML syntax) check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow attributes valid in html when converting from JSoup to W3C Document
2 participants