Improvements to recently introduced sourceinfo stuff #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change here is that
desc.Load*functions will always add source code info to the returned descriptors, if available.So the
descpackage now works "out of the box" to include source info if you are also using theprotoc-gen-gosrcinfoplugin. And for users of the v2 protobuf API, one can swap insourceinfo.GlobalFilesin place ofprotoregistry.GlobalFiles.This PR also tweaks the output of
protoc-gen-gosrcinfo, to eliminate an unnecessary import alias. And it adds a comment about the fact that thesrcinforeflectionpackage is experimental. With luck, a change can instead be upstreamed into the core gRPC reflection implementation that allows easily injectingsourceinfo.GlobalFiles.