Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run fuzzing in CI #432

Open
johanbrandhorst opened this issue Oct 27, 2021 · 1 comment · May be fixed by #433
Open

Run fuzzing in CI #432

johanbrandhorst opened this issue Oct 27, 2021 · 1 comment · May be fixed by #433

Comments

@johanbrandhorst
Copy link
Contributor

A few issues have been raised by fuzzing the parser (#334, #271, #233, #192), but so far it's only been done manually. The OSS-Fuzz project lets open source projects use their infrastructure to run fuzzing in CI: https://google.github.io/oss-fuzz/getting-started/continuous-integration/. For an example integration, see the grpc-gateway: grpc-ecosystem/grpc-gateway#2405. It appears the protoreflect project already exists in the projects directory, so it should just be a matter of adding a new CI job like for the grpc-gateway.
johanbrandhorst added a commit to johanbrandhorst/protoreflect that referenced this issue Oct 27, 2021
@johanbrandhorst
Add CI fuzzing
6715854 
Fixes jhump#432
@johanbrandhorst johanbrandhorst linked a pull request Oct 27, 2021 that will close this issue
Open
@jhump
Copy link
Owner

jhump commented Oct 27, 2021 •
edited

but so far it's only been done manually.

That's not entirely true. The Fuzzing is already done continuously. In fact it reported numerous issues that were all caused by one issue (fixed in #412).

It's just not part of the PR checks. (And, honestly, neither are the Circle CI checks for any contributed PRs -- for security reasons, Circle defaults to not running jobs if the source repo is a fork.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI fuzzing johanbrandhorst/protoreflect
2 participants
@jhump @johanbrandhorst