Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoparse: oneof with only groups results in error #314

Closed
jhump opened this issue Apr 26, 2020 · 1 comment
Closed

protoparse: oneof with only groups results in error #314

jhump opened this issue Apr 26, 2020 · 1 comment

Comments

@jhump
Copy link
Owner

jhump commented Apr 26, 2020

In #262, I added support for groups in oneofs. However, there was a latent bug in this functionality: if a oneof contains only groups (and no regular fields), then it results in an error during parsing: oneof must contain at least one field

Minimal reproducer:

message Foo { oneof bar { group Baz = 1 { optional int abc = 1; } } }
@jhump
Copy link
Owner Author

jhump commented Apr 27, 2020

Fixed in #316

@jhump jhump closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant