Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoparse: group fields inside oneofs should be able to have options #313

Closed
jhump opened this issue Apr 26, 2020 · 1 comment
Closed

protoparse: group fields inside oneofs should be able to have options #313

jhump opened this issue Apr 26, 2020 · 1 comment

Comments

@jhump
Copy link
Owner

jhump commented Apr 26, 2020

This was mostly already fixed by #285. However, I had only recently added group support to oneofs in #262 and failed to extend the options support to groups in oneofs.

Minimal reproducer:

message Foo {
  oneof bar {
    group Baz = 1 [deprecated=true] {
      optional int abc = 1;
    }
  }
}
@jhump jhump changed the title protobuf: group fields inside oneofs should be able to have options protoparse: group fields inside oneofs should be able to have options Apr 26, 2020
This was referenced Apr 26, 2020
Closed
Merged
@jhump
Copy link
Owner Author

jhump commented Apr 27, 2020

Fixed in #316

@jhump jhump closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhump