Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up automated test to compare protoc and protoparse output for src/google/protobuf/unittest.*proto? #309

Open
bufdev opened this issue Apr 8, 2020 · 0 comments

Comments

@bufdev
Copy link
Contributor

bufdev commented Apr 8, 2020

I can do this if you want.

What I'm thinking:

We likely will have to exclude SourceCodeInfo for this type of automated test, but even without that, it's useful.

Also would recommend doing this for googleapis.

Both #307 and #308 were discovered by effectively doing this manually.

Note there's some prior art, I can adapt https://github.com/bufbuild/buf/blob/c75b6195beced011672dbffd4a0a11d004ccbca4/internal/buf/bufbuild/builder_test.go for this purpose (this does it all in Golang).

@bufdev bufdev changed the title Set up automated test to compare protoc and protoparae output for src/google/protobuf/unittest.*proto? Set up automated test to compare protoc and protoparse output for src/google/protobuf/unittest.*proto? Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant