Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GOPROXY for gotip #259

Merged
merged 2 commits into from Aug 2, 2019
Merged

Disable GOPROXY for gotip #259

merged 2 commits into from Aug 2, 2019

Conversation

tie
Copy link
Contributor

@tie tie commented Aug 2, 2019

This PR ensures that issue like #258 would fail at CI stage by disabling GOPROXY for gotip (Go 1.13).

@jhump
Copy link
Owner

jhump commented Aug 2, 2019

Mind providing a TLDR on what these environment variables actually do?

@jhump
Copy link
Owner

jhump commented Aug 2, 2019

I guess rebasing this (now that #258 is merged) should make the test turn green, right?

@tie
Copy link
Contributor Author

tie commented Aug 2, 2019

Yes, rebasing will make the test green.

Both GOPROXY=https://proxy.golang.org,direct and GOSUMDB=sum.golang.org are defaults in Go 1.13.

  • GOPROXY=direct tells Go to download modules using direct connection
    to source control servers.

    The go command can fetch modules from a proxy or connect to source control
    servers directly, according to the setting of the GOPROXY environment
    variable.
    go help modules

  • GOSUMDB=off disables the global go.sum checksum database.

Now that I think about it, GOSUMDB probably should be left intact.

@tie tie changed the title Disable GOPROXY and GOSUMDB for gotip Disable GOPROXY for gotip Aug 2, 2019
@jhump
Copy link
Owner

jhump commented Aug 2, 2019

@tie, I'm guessing Go 1.13 has dropped support for GOPATH? I ask because GO111MODULE=on is not present for tip, but it appears to be using modules nevertheless.

@jhump jhump merged commit 8771ced into jhump:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants