Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protoparse cannot parse default float values with only '.' at the end #257

Closed
bufdev opened this issue Aug 1, 2019 · 2 comments
Closed

Comments

@bufdev
Copy link
Contributor

bufdev commented Aug 1, 2019

Another edge case:

// b.proto

syntax = "proto2";

message Foo {
  optional float one = 1 [default = 100.];
  optional double two = 2 [default = 200.];
}

I verified that 100 and 100.0 work.

@jhump
Copy link
Owner

jhump commented Aug 2, 2019

Interesting. I did not realize this was considered valid in protoc. I don't think this one is hard either though.

@jhump
Copy link
Owner

jhump commented Aug 2, 2019

Fixed in #262

@jhump jhump closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants