protoparse: make lexer do fewer allocations #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully removes a lot of the heap-allocations happening in the lexer. The
commentandSourcePosstructs were small, and we ended up allocating a lot of the latter. So hopefully copying them around will be more efficient (certainly less load on allocator/GC).This also removes some of the lambdas in the main
Lexmethod so the compiler doesn't need to heap-allocate local variables. Instead, the necessary state was added as fields to theprotoLexstruct, and the lambdas were promoted to methods onprotoLex.