Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vulnerable version of ansi-regex from dependencies #193

Merged
merged 3 commits into from
Dec 18, 2021

Conversation

tsekityam
Copy link
Contributor

@tsekityam tsekityam commented Sep 30, 2021

Dependabot cannot update ansi-regex to a non-vulnerable version
The latest possible version that can be installed is 4.1.0 because of the following conflicting dependency:

rewire@5.0.0 requires ansi-regex@^4.1.0 via a transitive dependency on strip-ansi@5.2.0
The earliest fixed version is 5.0.1.

View logs or learn more about troubleshooting Dependabot errors.

I got the above warning in one of my projects. It seems that the best way to fix this vulnerability is to upgrade mocha and eslint in this project to the latest version.

This PR upgrade mocha and eslint to the latest version, and also add the missing dev dependency istanbul to the repo.

I tried npm run test, npm run coverage and npm audit, and no warning or error was raised.

@makiri1993
Copy link

Any timeline when this will be released? I'm having the same issue and it's part of a ticket of mine :D

@imailer
Copy link

imailer commented Dec 13, 2021

@jhnns can you please review the PR and merge it ?

@jhnns
Copy link
Owner

jhnns commented Dec 14, 2021

I will try to review it this week 👍

@jhnns jhnns merged commit 9ec9276 into jhnns:master Dec 18, 2021
@jhnns
Copy link
Owner

jhnns commented Dec 18, 2021

LGTM, thank you 👍 :)

@jhnns
Copy link
Owner

jhnns commented Dec 19, 2021

Published as v6.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants