Add Firefox compatibility to stack trace test #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Published as v6.0.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on getting the shared test cases to run on both Firefox and Chrome, using webpack and (my fork of) rewire-webpack-plugin.
One test failed specifically in Firefox:
should not modify line numbers in stack traces. This happens, since Firefox uses a different stack trace format. This PR is a workaround for that. It's would have been possible to specifically code in for the Firefox format (although then you would have to check whether you are in Firefox or in a V8-engine), but usingerr.lineNumberanderr.columnNumberdirectly is cleaner.