From 228c4ed932fbd0dd6ed20ff2fe0834cc28ebe888 Mon Sep 17 00:00:00 2001 From: jhmaster2000 <32803471+jhmaster2000@users.noreply.github.com> Date: Tue, 29 Mar 2022 23:52:09 -0300 Subject: [PATCH] Remove node nightly tests warning checks (superseded by #1701) --- package.json | 4 ++-- src/test/esm-loader.spec.ts | 10 ++-------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 449a6f5b5..1f158f1fb 100644 --- a/package.json +++ b/package.json @@ -69,8 +69,8 @@ "build-tsc": "tsc", "build-configSchema": "typescript-json-schema --topRef --refs --validationKeywords allOf --out tsconfig.schema.json tsconfig.build-schema.json TsConfigSchema && node --require ./register ./scripts/create-merged-schema", "build-pack": "node ./scripts/build-pack.js", - "test-spec": "ava --node-arguments=--no-deprecation", - "test-cov": "nyc ava --node-arguments=--no-deprecation", + "test-spec": "ava", + "test-cov": "nyc ava", "test": "npm run build && npm run lint && npm run test-cov --", "test-local": "npm run lint-fix && npm run build-tsc && npm run build-pack && npm run test-spec --", "pre-debug": "npm run build-tsc && npm run build-pack", diff --git a/src/test/esm-loader.spec.ts b/src/test/esm-loader.spec.ts index 9a51d16a1..cc673e544 100644 --- a/src/test/esm-loader.spec.ts +++ b/src/test/esm-loader.spec.ts @@ -350,10 +350,7 @@ test.suite('esm', (test) => { const { err, stdout, stderr } = await cb(); expect(err).toBe(null); expect(stdout.trim()).toBe('CLI args: foo bar'); - // Nightly builds of Node.js might randomly start printing warnings, - // which would cause this test to fail despite actually working, - // so we should ignore stderr when testing on Node.js nightly. - if (!process.version.includes('nightly')) expect(stderr).toBe(''); + expect(stderr).toBe(''); }); } @@ -402,10 +399,7 @@ test.suite('esm', (test) => { `child registered signal handlers\nchild received signal: ${signal}\nchild exiting` ); } - // Nightly builds of Node.js might randomly start printing warnings, - // which would cause this test to fail despite actually working, - // so we should ignore stderr when testing on Node.js nightly. - if (!process.version.includes('nightly')) expect(stderr).toBe(''); + expect(stderr).toBe(''); }); } });